Few cleanups related to julia version, compats and tests of SurrogatesMOE #460
Conversation
|
@ArnoStrouwen, is there any reason we use old version of Tracker and Flux? I bumped the compat of Flux but it causes downgrade CI to fail - https://github.com/SciML/Surrogates.jl/actions/runs/7355008364/job/20022994040?pr=460 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
+ Coverage 77.93% 78.12% +0.19%
==========================================
Files 23 23
Lines 3155 3155
==========================================
+ Hits 2459 2465 +6
+ Misses 696 690 -6 ☔ View full report in Codecov by Sentry. |
|
In my PR, the CI fails for both regular and downgrade CI: I would put the flux compat to both 0.13 and 0.14. But if that turns out not to be possible, we will have to bump other packages also, which will then cause even more packages to need a bump and so on. The lower bound versions for downgrade CI are tedious to set up, but I'm quite experienced at it now, so I can do that part, as long as the random test result is fixed here. |
|
Yes, random test failures should be fixed |
Context
RandomSamplinglike in LanguageTool #459. This happens when one of the clusters in the Gaussian Mixture Model is empty. We should handle it more elegantly. I will look into it in a subsequent PR. To prevent spurious failures, I have changed it to use a deterministic method.